From: cummings@bbird8.Prime.COM (Kevin Cummings) Subject: Re: Kernel warnings Date: Wed, 14 Oct 1992 15:24:48 GMT
In article <1698@enst.enst.fr>, tardieu@helios.enst.fr (Samuel Tardieu) writes:
|> I have successfully compiled and installed the 0.98.1 Kernel with gcc 2.2.2d.
|> But during the compilation I had many warnings like "i is declared but never
|> used", "pointer converted to int without cast operator", and ps doesn't anything.
Yeah. Every once in a while Linus cleans up the code to remove warnings like this.
Then they start creaping back in with newly submitted code. It doesn't give me
any warm feeling about the people writing this kind of code. If the pointers are
really compatible, then CAST THEM to remove the warnings! I'd never pass code like
that in a code review where I work. Sigh. As for the unused variables, these might
either be there for debugging purposes, or just laziness on the part of a recent
code change. It's hard to find them when you compile with -g and never see them
until someone else compiles without it. Linus can't be expected to fix everyone
else's code, though he could set some minimum coding standards to try and avoid some
of these at submittal time.
|> Has someone already compiled this kernel ? I had to change the line gcc -static
|> into gcc in the Makefile too.
Sorry I can't remember if I had to do this or not. I've had some problems with my
patch not always putting the changed module into the correct place. Sometime I get
sources (and Makefiles) appearing in the current directory instead of the intended
target. If it's a Makefile or a commonly named header file, it only compounds when
finds another file with the same basename! Maybe my patch is out of date? It came
with the original shared utility package back with GCC 2.12....
=================================================================
Kevin J. Cummings PrimeService
20 Briarwood Road A Computervision Company
Framingham, Mass. 500 Old Connecticut Path
Framingham, Mass.
Work: cummings@primerd.Prime.COM
Home: cummings@kjc386.framingham.ma.us
Std. Disclaimer: "Mr. McKittrick, after careful consideration,
I've come to the conclusion that your new
defense system SUCKS..." -- War Games
=================================================================