From: scott@natinst.com (Scott A. Taylor) Subject: Re: 0.97 patch 2 problems Date: Tue, 25 Aug 1992 13:32:11 GMT
In article <1992Aug25.041238.8896@midway.uchicago.edu> ace3@midway.uchicago.edu writes:
>I found an apparent bug in mount_util.c in the distribution mount.src.tar.Z on tsx-11.mit.edu
>
>On line 64 change
>
> while (path && (p < absolute + PATH_MAX))
>
>to
> while (*path && (p < absolute + PATH_MAX))
> ^
> ...patch deleted...
>
>There is still some kind of problem with 'mount':
>mount -vt ext /dev/fd0 /a
>unrecognized option ``xy'' (ignored)
>/dev/fd0 on /a type ext (defaults)
>
>Where xy are 'weird' characters that didn't paste into this note. As I was tracing
>this through with gdb I got lost somewhere in getopt() and gave up for now.
>Mount is funtional, it just gives the 'unrecognized option ignored' message.
>
I had this problem too; putting lots of printf()s in mount showed me that
there is a problem with one of the string functions when it is passed a NULL
pointer rather than a true empty string. My solution was to check for a
NULL pointer and assign the pointer to an empty string if it was NULL. I don't
remember which function it was or where in mount.c I put the fix; the string
function was one of the string copying functions. If there's interest I'll
check at home tonight and post my fix tomorrow.
Incidentally, I'm running 0.96c pl2 and gcc 2.2.2. I still have problems
with mounting an MS-DOS filesystem; I think that the msdos fs code that is
in 0.96c pl2 has trouble dealing with the extended options scheme, since
undefining UGLY_MOUNT in the mount makefile allows me to mount an MS-DOS file-
system, but I lose the ability to mount stuff read-only, etc. (I know, I know,
I should upgrade to 0.97; I'm sure it's fixed by now).
>tony acero
>ace3@quads.uchicago.edu
>
>ps my home machine (quads.uchicago.edu) is down, probably until Tues. morning; any mail
--
Scott Taylor |
(512) 795-6837 | " " -Marcelle Marceau
scott@natinst.com |
** NI pays me to write their code, not their opinions **